fix(cli): prevent welcome() from re-triggering setup when a global config exists#2906
Merged
Conversation
welcome() triggered the setup wizard whenever the cwd lacked a reasonix.toml (SourcePath==""), even though config.Load() succeeds from the user-global config. Load early and gate the wizard on cfgErr != nil so it only runs when no config resolves from any source; drop the redundant src != "" guard on the chat-entry path for the same reason.
github-actions
Bot
added
the
v2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reasonixwith no args, run from a directory without a localreasonix.toml, re-ran the setup wizard even though a valid user-global config (~/.config/reasonix/config.toml) loads fine — because the trigger keyed onconfig.SourcePath() == ""(no cwd-local file) rather than on whether any config loads.Load early and gate the wizard on
cfgErr != nil, so it only runs when no config resolves from any source; drop the now-redundantsrc != ""guard on the chat-entry path.Supersedes #2859 by @Bernardxu123 (authorship preserved), reapplied onto current main-v2 to resolve the conflict with the evolved
interactiveSetupsignature.Validation
go build ./...,go vet ./internal/cli,go test ./internal/cli ./internal/config— pass.Closes #2856