Add pyproject.toml to have numpy available at install-time#77
Merged
esheldon merged 5 commits intoesheldon:masterfrom Jan 10, 2023
Merged
Add pyproject.toml to have numpy available at install-time#77esheldon merged 5 commits intoesheldon:masterfrom
numpy available at install-time#77esheldon merged 5 commits intoesheldon:masterfrom
Conversation
Owner
|
Sorry I let this one slip, can you please update for the newest version? |
Contributor
Author
|
I merged the latest |
Contributor
Author
|
Okay, the tests pass in my fork, so everything's probably fine. I accidentally added some generated files and deleted them again, but you might want to squash and merge this to avoid including that in the history. You might also want to add python 3.10 and 3.11 to the test suite, as a lot of people are probably on 3.10 by now. |
Owner
|
Thanks Jo. |
This was referenced Aug 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a version of the solution I mentioned in #76 (comment), adding a
pyproject.tomlfile to havenumpyavailable in thesetup.pyfile.I also made a few other changes that I think improve the package, but that aren't necessary (the only necessary part is the addition of the
pyproject.tomlfile):scipyto theinstall_requiresargument, because I thinkscipy, likenumpy, can now be reliably installed bypip(I've had it as a dependency for a long time ingalpyand nobody complains...)numpyis available insetup.py, so remove all code to deal with the case where it isn'tminiconda, but instead just usepipto install things. This is much faster, ~1 min. vs. 2.5 min. (pipinstalls ofnumpyandscipyare very fast, becausepipinstalls binary wheels). I also moved installs to the relevant section (e.g.,flake8in the linting step,pytestin the test step).