Conversation
…ed with header/row that does not exist
…limited strings OR JSON , but both. Processing might be slower, but more precise @alliomeria as explained in slack, PHP decodes some primitives as JSON. With this new approach, when we check for Strings we discard ANY JSON that would end in an ARRAY (when decoded) and instead treat them as strings. Then we re-parse the same data (more time processing but once does not do LoD of a complete AMI set in realtime over and over, so that is Ok) as JSON. This also allows Mixed case CSVs, where some rows are simple strings to be processed by One Metadata Display, but other rows proper JSON, and still have LoD reconciliation
… and ensure RETURN FALSE if not ARRAY
Will be used to pre-check on an Hook Update existing AMIs that have changed date prior to the request time (run time) of the hook Won't commit yet the hook bc the post/update logic is still missing (new tab at an AMI set + a warning letting the user know the attached CSV needs to be fixed (automatically or manually). This function could also be used on "replace/insert/add CSV" to any AMI set
…at was detected as "escaped" and needs to be fixed
…setting the status on CSV export
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #263
WIP. This does not deal with existing AMI CSVs that could have been wrongly escaped double quotes or any other character, from external or internal sources
Also no testing has been made since we don't have the multi sources CSVs yet