fix(render): handle nil changes when cycling tabs#309
Open
iamavolk wants to merge 1 commit intoesmuellert:mainfrom
Open
fix(render): handle nil changes when cycling tabs#309iamavolk wants to merge 1 commit intoesmuellert:mainfrom
iamavolk wants to merge 1 commit intoesmuellert:mainfrom
Conversation
when cycling through tabs more than once, the changes appear to be nil starting with the second cycle. As such, nil is passed down to the iterator factory. Add a defensive nil check beforehand
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setup:
gt(gT) to cycle around and get back to the same tab.What's changed:
This fix adds a defensive nil check before invoking the iterator.
Potential implications:
Maybe not the right place to handle the error since on the first cycling through tabs the untracked file has all of its entirety in the
lines_diff.changestable, and also renders momentarily.