Develop query ancillary#9
Draft
ashleythomasbarnes wants to merge 6 commits intoeso:develop-query_ancillaryfrom
Draft
Develop query ancillary#9ashleythomasbarnes wants to merge 6 commits intoeso:develop-query_ancillaryfrom
ashleythomasbarnes wants to merge 6 commits intoeso:develop-query_ancillaryfrom
Conversation
Introduces the query_ancillary method to EsoClass for querying Phase 3 ancillary product files from the ESO archive. Adds the phase3_product_files_table constant, a helper _normalize_product_ids, and a new test Jupyter notebook demonstrating the new functionality.
szampier
reviewed
Feb 16, 2026
| return column_list | ||
|
|
||
|
|
||
| def _normalize_product_ids(dp_id) -> List[str]: |
There was a problem hiding this comment.
missing type hint for the argument. Also I would like to see a short description since it's not so clear why we need this method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft of
query_ancillaryandlist_ancillaryfunctionality, which takes thedp_idof a product (or list from a number of products) and returns an astropy table of the ancillary file information. Makes use of the phase3v2.product_files table in TAP.