Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
TTS2 Template
for more information, see https://pre-commit.ci
Tts2 support parallel_wavgan vocoder
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Tomoki Hayashi <hayashi.tomoki@g.sp.m.is.nagoya-u.ac.jp>
Collaborator
Author
|
@sw005320 @simpleoier @kan-bayashi Hi guys, many thanks for your review! I've reflected on your comments and also added some unit tests for the functions added for tts2. We will have three following PRs after this one (would want to keep them separated to avoid a very large PR)
It would be great if you can double-check the existing PR so that we can merge it in the early place~ |
simpleoier
approved these changes
Apr 22, 2024
Contributor
|
Thanks for your great efforts, @ftshijt! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
The new task of discrete token-based TTS implementation (mostly focuses on acoustic modeling, by changing spectrogram to discrete token as output prediction)
TODO