Enable SCI sensor access from Lua#32
Open
rockets-cn wants to merge 1 commit intoespressif:masterfrom
Open
Conversation
Author
|
test in k10 it's worked. |
f50de86 to
d952181
Compare
DFRobot's RP2040 SCI module remains exposed through a dedicated Lua module after upstream split hardware peripherals into lua_driver components. The app_claw integration now keeps upstream's driver/module layout and adds only the SCI Kconfig option, component dependency, module registration hooks, and module README required by lua_module_builder. Constraint: Upstream master moved ADC/GPIO/I2C/MCPWM/TOUCH/UART into lua_driver entries, removed app_claw's manual CMake requires list, and now requires each Lua module to provide README.md for generated docs/skills. Rejected: Keep the original conflict-side app_claw CMake dependency additions | upstream now resolves component dependencies through idf_component.yml rules. Confidence: medium Scope-risk: narrow Directive: Keep SCI registered as a higher-level lua_module unless it is later split into a generic hardware driver API. Tested: Rebased onto origin/master fa0d2aa; resolved all conflict markers; git diff --check origin/master...HEAD; rg confirmed no conflict markers; idf.py build in application/edge_agent with ESP-IDF v5.5.4 and CN component registry mirror. Not-tested: Fresh hardware flash after conflict resolution; earlier pre-rebase build/flash on K10 succeeded.
d952181 to
e6a0ee3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lua_module_scicomponent for DFRobot RP2040 SCI readsVerification
idf.py buildidf.py -p /dev/cu.usbmodem2201 build flashNot Tested