GATT fixes (server-only, dynamic-services-only, no-bonds)#126
Open
nebkat wants to merge 3 commits into
Open
Conversation
When no non-dynamic services have been added the ble_gatts_clt_cfg_pool is empty. Because of this, it reports having no free blocks, as if it was full. We must check if there are any blocks available at all, in case they are all stored in dynamic services.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small fixes for build/runtime issues that appear when NimBLE is built with non-default configurations (server-only, dynamic-services-only, no bonds).
Commits
a656f28fix(nimble): Allow connections when only using dynamic servicesWhen only dynamic services are registered, the static
ble_gatts_clt_cfg_poolis initialized with zero blocks, somp_num_free == 0permanently —ble_gatts_conn_can_alloc()then refuses every connection. Treatmp_num_blocks == 0as "pool unused" rather than "pool exhausted".0307d1bfix(nimble): Guard ble_gattc_cache_refresh with BLE_GATTCble_gattc_cache_refresh()calls client-only APIs but sat outside the surrounding#if MYNEWT_VAL(BLE_GATTC)guard, breaking server-only builds. Moves the#endifpast the function.30f3498fix(nimble): Only allocate ble_gatts_conn_aware_states if MAX_BONDS > 0In
ble_gatts_start(), thenimble_platform_mem_calloc(1, sizeof(...) * BLE_STORE_MAX_BONDS)call zero-sizes whenBLE_STORE_MAX_BONDS == 0, and the subsequent NULL check then fails the start. Skip the allocation entirely when no bonds are configured.Checklist
Before submitting a Pull Request, please ensure the following: