fix(websocket): Fix leaking user_info if strdup for user or pass fails#1040
Open
rtrbt wants to merge 1 commit intoespressif:masterfrom
Open
fix(websocket): Fix leaking user_info if strdup for user or pass fails#1040rtrbt wants to merge 1 commit intoespressif:masterfrom
rtrbt wants to merge 1 commit intoespressif:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Low risk: small, localized change that only affects the error path when allocating username/password from a URI fails, preventing a memory leak.
Overview
Fixes a memory leak in
esp_websocket_client_set_uri()when parsinguserinfofrom the URI: ifstrdup()fails for the extracted username or password, the temporaryuser_infobuffer is now freed before returningESP_ERR_NO_MEM.Written by Cursor Bugbot for commit a79f77c. This will update automatically on new commits. Configure here.