Skip to content

[modem]: Build job with cmake v2#1043

Open
david-cermak wants to merge 2 commits intoespressif:masterfrom
david-cermak:feat/modem_cmake_v2
Open

[modem]: Build job with cmake v2#1043
david-cermak wants to merge 2 commits intoespressif:masterfrom
david-cermak:feat/modem_cmake_v2

Conversation

@david-cermak
Copy link
Copy Markdown
Collaborator

@david-cermak david-cermak commented Apr 13, 2026

followup on #1039


Note

Medium Risk
Moderate risk because it changes build-system integration for esp_modem and adds a new CI build path; failures could block builds across IDF v6/v2 configurations.

Overview
Adds a new CI job to build esp_modem’s ap_to_pppos example using ESP-IDF’s CMake build system v2 (IDF release-v6.0), generating a minimal top-level CMakeLists.txt and using EXTRA_COMPONENT_DIRS to avoid component manager override issues.

Updates components/esp_modem to detect IDF_BUILD_V2 and switch to a new CMakeLists_v2.txt that builds the component via add_library, wires include dirs/link deps, enforces C++17, and safely links idf::main only when present (for CONFIG_ESP_MODEM_ADD_CUSTOM_MODULE). Also tightens the ap_to_pppos example’s main component to explicitly REQUIRES its runtime dependencies.

Reviewed by Cursor Bugbot for commit f5d7f84. Bugbot is set up for automated code reviews on this repo. Configure here.

@david-cermak david-cermak self-assigned this Apr 13, 2026
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2a17f97. Configure here.

# Initialize lists before use to avoid inheriting variables from
# a parent component scope (recursive evaluation in v2).
set(public_deps)
set(optional_deps)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused optional_deps variable declared but never referenced

Low Severity

The optional_deps list is initialized on line 5 but is never populated or referenced anywhere in CMakeLists_v2.txt (or anywhere else in the codebase). Only public_deps is actually used. This appears to be leftover scaffolding — possibly intended for the optional main dependency handling at the bottom of the file, which ended up using a different approach (generator expression with TARGET_EXISTS).

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 2a17f97. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants