[modem]: Build job with cmake v2#1043
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2a17f97. Configure here.
| # Initialize lists before use to avoid inheriting variables from | ||
| # a parent component scope (recursive evaluation in v2). | ||
| set(public_deps) | ||
| set(optional_deps) |
There was a problem hiding this comment.
Unused optional_deps variable declared but never referenced
Low Severity
The optional_deps list is initialized on line 5 but is never populated or referenced anywhere in CMakeLists_v2.txt (or anywhere else in the codebase). Only public_deps is actually used. This appears to be leftover scaffolding — possibly intended for the optional main dependency handling at the bottom of the file, which ended up using a different approach (generator expression with TARGET_EXISTS).
Reviewed by Cursor Bugbot for commit 2a17f97. Configure here.
2a17f97 to
85a1515
Compare
85a1515 to
f5d7f84
Compare


followup on #1039
Note
Medium Risk
Moderate risk because it changes build-system integration for
esp_modemand adds a new CI build path; failures could block builds across IDF v6/v2 configurations.Overview
Adds a new CI job to build
esp_modem’sap_to_ppposexample using ESP-IDF’s CMake build system v2 (IDFrelease-v6.0), generating a minimal top-levelCMakeLists.txtand usingEXTRA_COMPONENT_DIRSto avoid component manager override issues.Updates
components/esp_modemto detectIDF_BUILD_V2and switch to a newCMakeLists_v2.txtthat builds the component viaadd_library, wires include dirs/link deps, enforces C++17, and safely linksidf::mainonly when present (forCONFIG_ESP_MODEM_ADD_CUSTOM_MODULE). Also tightens theap_to_ppposexample’smaincomponent to explicitlyREQUIRESits runtime dependencies.Reviewed by Cursor Bugbot for commit f5d7f84. Bugbot is set up for automated code reviews on this repo. Configure here.