Skip to content

fix(asio): Fix asio dependency issue#1047

Open
david-cermak wants to merge 2 commits intoespressif:masterfrom
david-cermak:fix/asio_deps
Open

fix(asio): Fix asio dependency issue#1047
david-cermak wants to merge 2 commits intoespressif:masterfrom
david-cermak:fix/asio_deps

Conversation

@david-cermak
Copy link
Copy Markdown
Collaborator

@david-cermak david-cermak commented Apr 17, 2026

Closes #1044


Note

Low Risk
Changes are limited to header include gating and CI/test additions; primary risk is an unintended build regression if ASIO_SOURCE isn’t set where expected.

Overview
Fixes a downstream build break where including asio.hpp could require sock_utils headers. socketpair.h is now included only when building Asio’s own translation unit (ASIO_SOURCE), keeping sock_utils off consumers’ include paths.

Adds a new components/asio/tests/build_test build-only regression project (and wires it into the GitHub Actions matrix with version exclusions) to ensure a component that only declares REQUIRES asio can compile and link.

Reviewed by Cursor Bugbot for commit 13777e3. Bugbot is set up for automated code reviews on this repo. Configure here.

@david-cermak david-cermak self-assigned this Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

asio cmakefile error

1 participant