fix(asio): Fix asio dependency issue#1047
Open
david-cermak wants to merge 2 commits intoespressif:masterfrom
Open
fix(asio): Fix asio dependency issue#1047david-cermak wants to merge 2 commits intoespressif:masterfrom
david-cermak wants to merge 2 commits intoespressif:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1044
Note
Low Risk
Changes are limited to header include gating and CI/test additions; primary risk is an unintended build regression if
ASIO_SOURCEisn’t set where expected.Overview
Fixes a downstream build break where including
asio.hppcould requiresock_utilsheaders.socketpair.his now included only when building Asio’s own translation unit (ASIO_SOURCE), keepingsock_utilsoff consumers’ include paths.Adds a new
components/asio/tests/build_testbuild-only regression project (and wires it into the GitHub Actions matrix with version exclusions) to ensure a component that only declaresREQUIRES asiocan compile and link.Reviewed by Cursor Bugbot for commit 13777e3. Bugbot is set up for automated code reviews on this repo. Configure here.