[qmsched] Add day-specific scheduling by RKBoss6 · Pull Request #4201 · espruino/BangleApps

RKBoss6 · 2026-03-26T17:27:29Z

Adds day specific scheduling using a bitmask similar to Alarms, and added a clockInfo for fast switching directly from the clock. Also created a method getQuietMode() that gets the mode active instead of clockinfo, and widgets doing it separately

Add function to retrieve the active quiet mode from settings.

Updated version and description to reflect new features.

Added support for day-specific scheduling and clock info.

Copilot

Pull request overview

Adds day-specific quiet-mode scheduling and exposes quick mode switching via a new Clock Info entry, while centralizing “current quiet mode” lookup into the qmsched library.

Changes:

Implement day-of-week filtering for scheduled quiet-mode changes (bitmask-based).
Add a clkinfo module for toggling quiet mode from clocks.
Add getMode() helper in lib.js and update the widget to use it.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 13 comments.

Show a summary per file

File	Description
apps/qmsched/app.js	UI updates to display/edit schedules with day bitmasks and a day picker menu
apps/qmsched/boot.js	Boot-time scheduler updated to select next schedule considering day masks
apps/qmsched/clkinfo.js	New clockinfo item to view/toggle quiet mode quickly
apps/qmsched/lib.js	Adds `getMode()` accessor for the active quiet mode
apps/qmsched/widget.js	Uses `qmsched.getMode()` when rendering the widget
apps/qmsched/metadata.json	Version bump, tags updated, and clkinfo file added to storage list
apps/qmsched/ChangeLog	Notes new day-specific scheduling and clkinfo addition

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-26T17:33:16Z

apps/qmsched/app.js

+    menu[B2 ? "Save" : "> Save"] = function() {
+      if (isNew) scheds.push(getSched());
+      else scheds[index] = getSched();
      save();
      showMainMenu();
    };
+    if (!isNew) {
+      menu[B2 ? "Delete" : "> Delete"] = function() {


The Save label introduced here ("Save" / "> Save") is user-facing but isn’t marked with /*LANG*/ like other strings in this file. Please add translation markers (and keep B2/non-B2 variants consistent).

Suggested change

menu[B2 ? "Save" : "> Save"] = function() {

if (isNew) scheds.push(getSched());

else scheds[index] = getSched();

save();

showMainMenu();

};

if (!isNew) {

menu[B2 ? "Delete" : "> Delete"] = function() {

menu[B2 ? /*LANG*/"Save" : /*LANG*/"> Save"] = function() {

if (isNew) scheds.push(getSched());

else scheds[index] = getSched();

save();

showMainMenu();

};

if (!isNew) {

menu[B2 ? /*LANG*/"Delete" : /*LANG*/"> Delete"] = function() {

Copilot · 2026-03-26T17:33:17Z

apps/qmsched/app.js

+      menu[B2 ? "Delete" : "> Delete"] = function() {
+        scheds.splice(index, 1);
+        save();
+        showMainMenu();
+      };


The Delete label introduced here ("Delete" / "> Delete") is user-facing but isn’t marked with /*LANG*/. Please add translation markers for localization consistency.

apps/qmsched/clkinfo.js

Copilot · 2026-03-26T17:33:17Z

apps/qmsched/widget.js

    area: "tl",
    width: ((require("Storage").readJSON("setting.json", 1) || {}).quiet|0) ? 24 : 0,
    draw: function() {
-      const mode = (require("Storage").readJSON("setting.json", 1) || {}).quiet|0;
+      const mode = require("qmsched").getMode();


Widget width is still computed by directly reading setting.json, while draw() now uses require("qmsched").getMode(). Using the same helper for both avoids duplicated logic and keeps widget initialization consistent with future changes to how the active mode is determined.

Copilot · 2026-03-26T17:33:18Z

apps/qmsched/app.js

+function showDaysMenu(mask, onDone) {
+  let cur = mask;
+  let menu = {"": {title: "Active Days"}};
+  menu["< Back"] = () => onDone(cur);


The new menu title/label strings here (eg "Active Days", "< Back") are user-facing but aren’t marked with /*LANG*/ like the rest of this file. Please add translation markers to keep localization consistent.

Copilot · 2026-03-26T17:33:19Z

apps/qmsched/clkinfo.js

+          let txt="Off";
+          let img=atob("GBgBAAAAAAAAAAAAABwAABwAAH8AAP+AAf/AA//gA//gA//gB//wA//gA//gA//gA//gA//gA//gABwAAD4AABwAAAgAAAAAAAAA");
+          if(mode==1){
+            txt="Alarms";
+            img=atob("GBgBAAAAAAAAAAgAAP+AA//gB//wD//4D//4H//8H//8AAAAAAAAIADiAADgAADgH/nwH/nwD/P4D/P4B/hAA/zgAPnwAAjgAABA")


The clockinfo get() path builds img by decoding base64 with atob(...) on each call. Since these icons are constant, consider decoding once (module-level consts) and reusing them to reduce allocations/CPU during redraws.

Copilot · 2026-03-26T17:33:19Z

apps/qmsched/app.js

+const dayNames = ["Su","Mo","Tu","We","Th","Fr","Sa"];
+
+function formatDays(mask) {
+  if (!mask || mask === allDays) return "Every day";


formatDays treats a 0 bitmask as "Every day" because of the !mask check. However the scheduler logic treats a 0 mask as "no active days" (won’t ever trigger). Consider distinguishing undefined/missing from 0, and either prevent persisting days:0 or display it as "No days".

Suggested change

if (!mask || mask === allDays) return "Every day";

if (mask == null) return "Every day"; // undefined/null => default to every day

if (mask === 0) return "No days";

if (mask === allDays) return "Every day";

apps/qmsched/app.js

apps/qmsched/lib.js

Copilot · 2026-03-26T17:33:20Z

apps/qmsched/lib.js

+/**
+ * Get the active quiet mode
+ * Returns: (int) active quiet mode
+ */
+exports.getMode = function(){


PR description mentions adding getQuietMode(), but this change introduces getMode() instead. Please align the PR description/changelog with the exported API name (or rename the function) to avoid confusion for consumers.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

bobrippling · 2026-03-27T19:04:36Z

Drop me an @ when you're happy :)

RKBoss6 · 2026-04-02T11:28:56Z

Not sure about these lint errors - from what I can tell, they had long exemptions and are now gone due to edits. Would I re-add those lint exemptions, or try to fix it?

RKBoss6 added 11 commits March 22, 2026 17:40

Implement getMode function for quiet mode retrieval

40c9532

Add function to retrieve the active quiet mode from settings.

Bump version to 0.11 and update description

a19c1d7

Updated version and description to reflect new features.

Bump version

10ed589

Added support for day-specific scheduling and clock info.

Refactor mode retrieval in qmsched widget

e2ae66c

Add clkinfo.js for quiet mode toggle functionality

22cc6fe

Update metadata.json

ecfefb1

Change var to let for mode in clkinfo.js

ee1d136

Emit 'qmchange' event when applying quiet mode

30ee7cc

remove qmsched emit

cc0c68c

Add setting for days and saving them

7cc4692

check for days active and set mode based on that

c0ac522

Copilot AI review requested due to automatic review settings March 26, 2026 17:27

Copilot started reviewing on behalf of RKBoss6 March 26, 2026 17:27 View session

Copilot AI reviewed Mar 26, 2026

View reviewed changes

Update apps/qmsched/clkinfo.js

ded2299

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

RKBoss6 marked this pull request as draft March 26, 2026 17:45

RKBoss6 and others added 2 commits March 26, 2026 13:45

Update apps/qmsched/lib.js

9b9fe52

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update apps/qmsched/app.js

0295fff

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[qmsched] Add day-specific scheduling#4201

[qmsched] Add day-specific scheduling#4201
RKBoss6 wants to merge 14 commits intoespruino:masterfrom
RKBoss6:qmsched-final

RKBoss6 commented Mar 26, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 26, 2026

Uh oh!

Copilot AI Mar 26, 2026

Uh oh!

Uh oh!

Copilot AI Mar 26, 2026

Uh oh!

Copilot AI Mar 26, 2026

Uh oh!

Copilot AI Mar 26, 2026

Uh oh!

Copilot AI Mar 26, 2026

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 26, 2026

Uh oh!

bobrippling commented Mar 27, 2026

Uh oh!

RKBoss6 commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

-  if (!mask || mask === allDays) return "Every day";
+  if (mask == null) return "Every day"; // undefined/null => default to every day
+  if (mask === 0) return "No days";
+  if (mask === allDays) return "Every day";

Conversation

RKBoss6 commented Mar 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

bobrippling commented Mar 27, 2026

Uh oh!

RKBoss6 commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants