TOOL-700: Add native attachments#2496
Open
the-nick-fischer wants to merge 8 commits intoesrlabs:native-uifrom
Open
TOOL-700: Add native attachments#2496the-nick-fischer wants to merge 8 commits intoesrlabs:native-uifrom
the-nick-fischer wants to merge 8 commits intoesrlabs:native-uifrom
Conversation
the-nick-fischer
force-pushed
the
native_attachments
branch
from
2096aa9 to
ff88b6e
Compare
the-nick-fischer
force-pushed
the
native_attachments
branch
3 times, most recently
from
b1750c0 to
3831bbf
Compare
the-nick-fischer
force-pushed
the
native_attachments
branch
from
514684a to
398de41
Compare
the-nick-fischer
force-pushed
the
native_attachments
branch
from
398de41 to
64164ab
Compare
the-nick-fischer
force-pushed
the
native_attachments
branch
from
ec77f14 to
3366ff8
Compare
| let attachment = self | ||
| .shared | ||
| .attachments | ||
| .attachment_by_log_position(cell.row_nr as usize); |
Author
There was a problem hiding this comment.
@AmmarAbouZor
Using the row number is not correct here. We need to fetch the position in the logs table instead. Could you help here?
Also how do I deal with the type conversion here? Do we support 32-bit?
Member
There was a problem hiding this comment.
We can get the grabbed element via self.get_log_item(cell) which contains the position of the log.
We already get this info here at line 186:
let bookmark_pos = self.get_log_item(cell).map(|item| item.element.pos as u64);You can set the log item to a variable here and use it for both bookmarks and attachments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TOOL-700: This PR adds a basic implementation of the attachments panel to the native UI:
What is missing: