feat!: move environment-specific plugins to optional peer dependencies#546
Open
JoshTheWanderer wants to merge 4 commits intomainfrom
Open
feat!: move environment-specific plugins to optional peer dependencies#546JoshTheWanderer wants to merge 4 commits intomainfrom
JoshTheWanderer wants to merge 4 commits intomainfrom
Conversation
Environment-specific ESLint plugins (angular-eslint, @next/eslint-plugin-next, eslint-plugin-react, eslint-plugin-jsx-a11y, eslint-plugin-react-hooks, eslint-plugin-lit, @darraghor/eslint-plugin-nestjs-typed) are now optional peer dependencies instead of optional dependencies. This means npm will no longer automatically install them — consumers must explicitly install only the plugins they need for their environment. BREAKING CHANGE: Environment-specific plugins are no longer installed automatically. Users must manually install the peer dependencies required for their chosen config (e.g. `npm install angular-eslint` when using `@etchteam/eslint-config/angular`). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mergify
bot
requested review from
a team and
ella-etch
and removed request for
a team
The plugins are needed as devDependencies so they're available when linting the source code and running test configs in CI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
DanWebb
approved these changes
Mar 31, 2026
DanWebb
previously approved these changes
Mar 31, 2026
| }, | ||
| "eslint-plugin-react-hooks": { | ||
| "optional": true | ||
| }, |
Member
There was a problem hiding this comment.
🎯 suggestion: It'd probably be helpful to document which peer dep(s) is needed for which config in the readme
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
# Conflicts: # package-lock.json
|
DanWebb
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
optionalDependenciesto optionalpeerDependenciesBREAKING CHANGE
Environment-specific plugins are no longer installed automatically. Users must manually install the peer dependencies required for their chosen config. For example:
Affected plugins
angular-eslintangular@next/eslint-plugin-nextnextjseslint-plugin-reactreact,nextjs,preact, defaulteslint-plugin-jsx-a11yreact,nextjs,preact, defaulteslint-plugin-react-hooksnextjseslint-plugin-litweb-components@darraghor/eslint-plugin-nestjs-typednestjs🤖 Generated with Claude Code