Skip to content

Menubar anchor target#316

Merged
DanWebb merged 2 commits intomainfrom
wrap-1970-tab-menu-target-size
Nov 12, 2025
Merged

Menubar anchor target#316
DanWebb merged 2 commits intomainfrom
wrap-1970-tab-menu-target-size

Conversation

@DanWebb
Copy link
Copy Markdown
Member

@DanWebb DanWebb commented Nov 12, 2025

Makes anchors fill the whole tab so that both the background and text is clickable.

Additional fix to make tabs fill the height of the menubar inner div to stop this kind of thing happening...

Screenshot 2025-11-12 at 16 02 35 Screenshot 2025-11-12 at 16 02 47

@sonarqubecloud
Copy link
Copy Markdown

@mergify mergify bot requested a review from a team November 12, 2025 16:07
@github-actions
Copy link
Copy Markdown

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ CSS stylelint 1 0 1.19s
✅ EDITORCONFIG editorconfig-checker 1 0 0.01s
✅ REPOSITORY checkov yes no 20.47s
✅ REPOSITORY gitleaks yes no 6.71s
✅ REPOSITORY git_diff yes no 0.02s
✅ REPOSITORY secretlint yes no 1.47s
✅ REPOSITORY trivy-sbom yes no 3.22s
✅ REPOSITORY trufflehog yes no 6.31s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the clickability of menubar tabs by making anchor elements fill the entire tab area, and fixes height issues to ensure tabs properly fill the menubar's inner div.

Key Changes:

  • Made anchor elements fill the entire tab area using flexbox properties and 100% height/width
  • Added height: 100% to tab-inner to prevent layout gaps
  • Conditionally removed padding from tab-inner when it contains an anchor to prevent double padding

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@DanWebb DanWebb merged commit a1be667 into main Nov 12, 2025
21 checks passed
@DanWebb DanWebb deleted the wrap-1970-tab-menu-target-size branch November 12, 2025 16:51
@DanWebb
Copy link
Copy Markdown
Member Author

DanWebb commented Nov 12, 2025

🎉 This issue has been resolved in version 9.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants