Feature ETP-1917: Enable SSL Support for PostgreSQL Connections in dbsourcemanager#11
Conversation
|
Warning Git Police 👮One or more commit messages do not meet the required standards. Please correct them.
|
There was a problem hiding this comment.
Pull request overview
This pull request adds SSL connection support to the database source manager by modifying the getUnpooledConnection() method in DBSMOBUtil.java. The implementation enables secure PostgreSQL connections through configurable SSL parameters, with support for custom SSL factories and root certificate validation.
Key changes:
- Introduced dynamic connection properties building with SSL configuration support (bbdd.ssl, bbdd.sslmode, bbdd.sslfactory, bbdd.sslrootcert)
- Added validation logic for SSL root certificate files with error handling for missing or invalid certificates
- Enhanced error reporting by wrapping SQLException in RuntimeException with descriptive messages
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d6fa2bc to
0aec24d
Compare
etendobot
left a comment
etendobot
left a comment
There was a problem hiding this comment.
Changes requested by agent. Please resolve blocking issues.
0aec24d to
1e43aaa
Compare
|
This pull request enhances the way database connections are established in
DBSMOBUtil.java, specifically by adding support for SSL configuration when connecting to the database. The changes make the connection logic more robust and flexible, allowing for secure connections with customizable SSL parameters.Database connection improvements:
bbdd.ssl,bbdd.sslmode,bbdd.sslfactory, andbbdd.sslrootcert). If SSL is enabled, the code now checks for the presence ofbbdd.sslfactoryand uses it if specified; otherwise, it requires a valid root certificate file for certain SSL modes.RuntimeExceptionif SSL configuration is invalid or if the root certificate file is missing when required. Also added a more descriptive error message when failing to obtain a connection.