Feature ETP-3800: migrate financial bundle to Jakarta/Hibernate 6#992
Feature ETP-3800: migrate financial bundle to Jakarta/Hibernate 6#992RomanMagnoli wants to merge 13 commits into
Conversation
| id 'jacoco' | ||
| id 'com.etendoerp.gradleplugin' version '3.0.0-SNAPSHOT' | ||
| id 'com.etendoerp.gradleplugin' version '3.0.1-SNAPSHOT' | ||
| id 'com.etendoerp.testing.gradleplugin' version '3.0.0-SNAPSHOT' |
There was a problem hiding this comment.
Suggestion
Consider using a stable version of the Etendo Gradle Plugin instead of a SNAPSHOT if one is available and compatible with the Jakarta/Hibernate 6 migration requirements.
id 'com.etendoerp.gradleplugin' version '3.0.1' // Or a stable Confirmed Stable (CS) version when availableRationale: Using SNAPSHOT versions is suitable for development but can lead to non-reproducible builds if the snapshot changes. It is recommended to use a stable version for releases.
etendobot
left a comment
etendobot
left a comment
There was a problem hiding this comment.
Changes requested by agent. Please resolve blocking issues.
077880a to
4541a24
Compare
| env.JAVA_HOME = "/usr/lib/jvm/jdk-17.0.13" | ||
| env.TOMCAT_URL = "https://dlcdn.apache.org/tomcat/tomcat-11/v11.0.15/bin/apache-tomcat-11.0.15.tar.gz" | ||
| env.TOMCAT_URL = "https://dlcdn.apache.org/tomcat/tomcat-11/v11.0.21/bin/apache-tomcat-11.0.21.tar.gz" | ||
| env.STACK_TYPE = "PRERELEASE 27Q1" |
There was a problem hiding this comment.
Suggestion
The update to Tomcat 11.0.21 is correct for the Jakarta migration context. No changes needed.
env.TOMCAT_URL = "https://dlcdn.apache.org/tomcat/tomcat-11/v11.0.21/bin/apache-tomcat-11.0.21.tar.gz"Rationale: Updating the Tomcat version to 11.0.21 is a standard maintenance practice for CI pipelines to include security fixes and performance improvements. This is consistent with the Jakarta/Hibernate 6 migration requirements.
| env.JAVA_HOME = "/usr/lib/jvm/jdk-17.0.13" | ||
| env.TOMCAT_URL = "https://dlcdn.apache.org/tomcat/tomcat-11/v11.0.15/bin/apache-tomcat-11.0.15.tar.gz" | ||
| env.TOMCAT_URL = "https://dlcdn.apache.org/tomcat/tomcat-11/v11.0.21/bin/apache-tomcat-11.0.21.tar.gz" | ||
| env.STACK_TYPE = "PRERELEASE 27Q1" |
There was a problem hiding this comment.
Suggestion
Verify the Tomcat version and URL. If Tomcat 11 is intended, consider using the latest stable version (e.g., 11.0.2). If Tomcat 10.1 was intended (which is common for Jakarta EE 10/Hibernate 6 migrations), update both the path and the version number.
env.TOMCAT_URL = "https://dlcdn.apache.org/tomcat/tomcat-11/v11.0.2/bin/apache-tomcat-11.0.2.tar.gz"Rationale: As of current public releases, Tomcat 11.0.21 does not exist on Apache mirrors (latest stable is 11.0.2). Using an invalid URL will cause the Jenkins pipeline to fail during the download stage. This might be a typo for Tomcat 10.1.21, which is a valid version often used for Jakarta EE 10 migrations, or it should be updated to a valid Tomcat 11 stable version if Jakarta EE 11 features are required.
9679384 to
42117be
Compare
|
0 New Issues
2 Fixed Issues
0 Accepted Issues2 participants
Summary
hibernate-jakarta-migration-guide.md./gradlew compile.completeValidation