Feature ETP-4529: Emit dimensionsPanel column in generate-frontend#51
Open
Gremiger wants to merge 2 commits into
Open
Feature ETP-4529: Emit dimensionsPanel column in generate-frontend#51Gremiger wants to merge 2 commits into
Gremiger wants to merge 2 commits into
Conversation
Contributor
|
📦 Preview packages published — dist-tag To exercise the published-package path (no make bump-core-version VERSION=0.3.12-preview.feature-ETP-4529.20260718224403.f35e27aAuto-updated on each push to this branch; supersedes older previews. |
Collect fields flagged decisions.json dimensionsPanel:true into one synthetic grid column instead of individual columns, so the shared "Dimensiones contables" expand-row UX works on pipeline-generated lines tables, not just hand-written custom components. Fully additive: verified byte-identical output on an unaffected window. Also fixes resolve-curated.js's missing SF_ROOT override, which silently broke LOCAL_CORE dev mode for --write.
Gremiger
force-pushed
the
feature/ETP-4529
branch
from
July 18, 2026 22:42
6c61fd3 to
f35e27a
Compare
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dimensionsPanel: truedecisions.json flag (alongside the existinggridboolean) that groups fields into a single syntheticdimensionsPanelgrid column instead of individual columns, for the expand-row "Dimensiones contables" UX.resolve-curated.js(FIELD_DECISION_COPY_PROPS) andgenerate-contract.js(applyGridHints), read independently ofgrid.generate-frontend.js'sgenerateTableComponentexcludesdimensionsPanelfields from the normal grid-columns pass and emits one combined column (always last) via newbuildDimensionsPanelColumn/buildDimensionFieldLiteralhelpers.SF_ROOTenv fallback gap inresolve-curated.jsthat brokeLOCAL_COREdev-mode usage (every sibling script already had this fallback).cli/test/generate-frontend.test.js.Why
Companion to
etendo_schema_forge's ETP-4529 work (accounting dimension visibility) — the app-shell side already has a genericInlineLinesPaneldimensionsPanelcolumn type (extracted from Amortización's existing expand-row pattern), but 4 windows (sales-invoice, purchase-invoice, goods-shipment, goods-receipt) turned out to have pipeline-generated line tables with no working custom-override point, so the generator itself needed to support emitting this column type.Test plan
node --test 'cli/test/*.test.js'— 2439 pass, 0 fail (baseline 2436 + 3 new)physical-inventory(zerodimensionsPanelfields) before/after — byte-identical output, onlyupdatedAtdiffersLOCAL_CORE=1end-to-end verification against all 4 target windows inetendo_schema_forge(sales-invoice, purchase-invoice, goods-shipment, goods-receipt) — generated tables correctly declare the new column with per-window field overridesetendo_schema_forge's core pin to the preview package published from this PR, then Alex (reviewer) pass across both repos before merging toepic/ETP-3504