Skip to content

Feature ETP-4609: Fix product grid filter panel bugs#68

Merged
RubenEtendo merged 25 commits into
epic/ETP-3504from
feature/ETP-4609
Jul 24, 2026
Merged

Feature ETP-4609: Fix product grid filter panel bugs#68
RubenEtendo merged 25 commits into
epic/ETP-3504from
feature/ETP-4609

Conversation

@IrinaUrri

@IrinaUrri IrinaUrri commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Jira: https://etendoproject.atlassian.net/browse/ETP-4609

Scope (this repo — schema_forge_core / @etendosoftware/app-shell-core)

This repo owns the generic grid filter component, so it carries the shared fix for bug 1 plus the fully backend-independent bug 3 and bug 4:

  • Bug 1 (generic fix): grid filter operator/column rules corrected so invalid operator/column combinations are no longer offered (isNull-type ops hidden on required columns, ghost/non-filterable columns excluded from the operator list).
  • Bug 3 / Bug 4: the inSet filter was case-sensitive, causing valid matches to be silently dropped when casing didn't line up; made case-insensitive.

Commits (test-first, per Bug/Pasada1 QA-gated process)

  1. Add failing tests for grid filter panel bugs — reproduces bug 1 (bad operator/column combos)
  2. Hide isNull ops on required + exclude ghost cols — fixes bug 1
  3. Document filter operator/column rules — docs for the bug 1 fix
  4. Add failing test for case-sensitive inSet filter — reproduces bug 3/4
  5. Make inSet filter case-insensitive — fixes bug 3/4
  6. Document case-insensitive inSet filter — docs for the fix

⚠️ Follow-up required before this takes effect for functional windows

This package is consumed by etendo_schema_forge as the published @etendosoftware/app-shell-core dependency (default profile — see docs/repo-topology.md there). These fixes will not reach functional windows outside LOCAL_CORE dev mode until this package is published and version-bumped in etendo_schema_forge. That publish + bump is a known follow-up, out of scope for this PR.

Companion PRs

Part of a lockstep 3-repo change for ETP-4609. Companion PRs:

@IrinaUrri IrinaUrri self-assigned this Jul 23, 2026
@IrinaUrri IrinaUrri changed the title Feature ETP-4609: Correcciones en los filtros de la grilla de Productos Feature ETP-4609: Fix product grid filter panel bugs Jul 23, 2026
@sonarscanetendo

Copy link
Copy Markdown

Passed Quality Gate passed

Issues

Measures

Project ID: etendosoftware_schema_forge_core_976a1e0b-4b24-4757-a2f4-8afa9a5e0289

View in SonarQube

@github-actions

Copy link
Copy Markdown
Contributor

📦 Preview packages published — dist-tag alpha

0.3.17-preview.feature-ETP-4609.20260724103804.f11804e

To exercise the published-package path (no LOCAL_CORE), bump all
core pins to this preview in the functional repo and reinstall:

make bump-core-version VERSION=0.3.17-preview.feature-ETP-4609.20260724103804.f11804e

Re-posted on each push to this branch; supersedes older previews.

@RubenEtendo
RubenEtendo merged commit f8b672d into epic/ETP-3504 Jul 24, 2026
13 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Epic rollout entry

Feature PR: #68 Feature ETP-4609: Fix product grid filter panel bugs
Merged into epic: 2026-07-24

{
  "number": 68,
  "title": "Feature ETP-4609: Fix product grid filter panel bugs",
  "url": "https://github.com/etendosoftware/schema_forge_core/pull/68",
  "author": "IrinaUrri",
  "mergedAt": "2026-07-24T18:26:16Z",
  "summaryBullets": [],
  "reviewReport": {
    "outcome": "Not found",
    "blockers": [],
    "warnings": []
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants