Feature ETP-4657: Fix semantic color token drift from ETP-4554#71
Merged
Merged
Conversation
- Restore --foreground/--muted-foreground/--border-subtle to match the original design (verified against staging) after they drifted to unaudited generic shadcn defaults during the ETP-4554 migration. - Revert --border-control/--input to the original light color: it drove both real form-control borders AND shared outline buttons, so its WCAG 1.4.11 fix visually broke buttons too. Documented as an accepted, known a11y gap (WARN comments) instead of silently dropped. - Add ALIAS_TOKEN_PAIRS consistency check (theme/index.js + accessibility.test.js) so generic tokens can't silently drift from the audited accessibility contract again. - Fix shared TableRow/TableHeader/TableFooter: used border-structural (WCAG 3:1-gated, meant for real structural boundaries) for plain decorative row/section dividers; switched to border-subtle.
Contributor
|
📦 Preview packages published — dist-tag To exercise the published-package path (no make bump-core-version VERSION=0.3.16-preview.feature-ETP-4657-colors-epic.20260723232055.e5f7115Re-posted on each push to this branch; supersedes older previews. |
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage
Contributor
Epic rollout entryFeature PR: #71 Feature ETP-4657: Fix semantic color token drift from ETP-4554 {
"number": 71,
"title": "Feature ETP-4657: Fix semantic color token drift from ETP-4554",
"url": "https://github.com/etendosoftware/schema_forge_core/pull/71",
"author": "sebastianbarrozo",
"mergedAt": "2026-07-23T23:47:21Z",
"summaryBullets": [
"Restore `--foreground`/`--muted-foreground`/`--border-subtle` to match the original design (verified against staging) after they drifted to unaudited generic shadcn defaults during the ETP-4554 migration.",
"Revert `--border-control`/`--input` to the original light color (shared by real form-control borders AND buttons); its WCAG 1.4.11 darkening broke button visuals. Documented as an accepted, known a11y gap instead of silently dropped.",
"Add `ALIAS_TOKEN_PAIRS` consistency check so generic tokens can't silently drift from the audited accessibility contract again.",
"Fix shared `TableRow`/`TableHeader`/`TableFooter`: used `border-structural` (WCAG 3:1-gated) for plain decorative dividers instead of `border-subtle`."
],
"reviewReport": {
"outcome": "Not found",
"blockers": [],
"warnings": []
}
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick of the color-regression fix from
feature/ETP-4657(that branch's PR #69 is still pending the rest of the quick-wins sweep) — landing just this fix on epic now to fix the "Base branch is green" CI failures other PRs are seeing.--foreground/--muted-foreground/--border-subtleto match the original design (verified against staging) after they drifted to unaudited generic shadcn defaults during the ETP-4554 migration.--border-control/--inputto the original light color (shared by real form-control borders AND buttons); its WCAG 1.4.11 darkening broke button visuals. Documented as an accepted, known a11y gap instead of silently dropped.ALIAS_TOKEN_PAIRSconsistency check so generic tokens can't silently drift from the audited accessibility contract again.TableRow/TableHeader/TableFooter: usedborder-structural(WCAG 3:1-gated) for plain decorative dividers instead ofborder-subtle.Test plan
npm test --workspace=packages/app-shell-core— 695/695 pass