feat(sdm): acceptance tests coverage; SDM post-exec replay RPC, tooling#20357
Closed
nonsense wants to merge 2 commits into
Closed
feat(sdm): acceptance tests coverage; SDM post-exec replay RPC, tooling#20357nonsense wants to merge 2 commits into
nonsense wants to merge 2 commits into
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #20357 +/- ##
==========================================
- Coverage 11.0% 4.2% -6.8%
==========================================
Files 692 563 -129
Lines 76899 70757 -6142
==========================================
- Hits 8483 3000 -5483
+ Misses 68272 67613 -659
Partials 144 144
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
50cf532 to
4c5f237
Compare
450a794 to
6ea60b6
Compare
… Interop fork Collapses the previously split SDM gate (op-node IsSDM=IsInterop CL gate + op-reth --rollup.sdm-enabled EL flag) into a single chain-spec source of truth. Both layers now read IsInterop(timestamp) from the same chain spec, so they cannot drift. - op-reth: replace sdm_enabled bool field threaded through OpEvmConfig, OpBuilderConfig, OpExecutorBuilder, OpPayloadBuilder, OpAddOns, OpAddOnsBuilder, OpEthApiBuilder, and OpReceiptConverter with a direct OpHardforks::is_interop_active_at_timestamp lookup at the relevant block/next-block timestamp. Remove --rollup.sdm-enabled CLI flag and matching with_sdm_enabled builders, and the integration test that only exercised the dropped flag. - op-devstack: remove OpRethWithSDMEnabled() helper (the flag is gone). - op-acceptance-tests/sdm: drive sdmEnabled via WithForkAtOffset(Interop, ...) in DeployerOptions instead of the EL flag, and assert Interop matches the desired SDM state so a preset change that pushed Interop out of the test window would fail loudly instead of silently no-op'ing. - op-acceptance-tests/sdm: add TestSDMActivatesAtInteropBoundary exercising the chain-spec gate across the Interop activation timestamp. - op-acceptance-tests/sdm/block_test.go: fix suptypes.CrossSafe -> safety.CrossSafe (rebase artifact; op-supervisor/supervisor/types no longer exports CrossSafe). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
6ea60b6 to
ecee101
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
op-acceptance-testsintegration coverage for SDM on op-reth, backed by a newdebug_replaySDMBlockRPC and lightweight Go replay client.Acceptance tests
This PR adds four SDM op-acceptance tests:
TestSDMDisabledNoRefundsverifies SDM-disabled op-reth nodes do not emit post-exec transactions oropGasRefund.TestSDMEnabledPayloadAndReplayMatchverifies post-exec payload refunds, receiptopGasRefund, replayed refunds, and block gas accounting all match.TestSDMStorageRefundBreakdownverifies exact warm storage refund attribution for same-slot and many-slot workloads.TestSDMMixedWorkloadSmokesubmits a batched mixed workload across transfers, compute, logs, and state writes.Main changes
SDMEnabledflag to mixed op-reth devstack setup.debug_replaySDMBlockto op-reth for replaying historical blocks with post-exec enabled.op-chain-ops/pkg/sdmreplayhelpers for calling the replay RPC and comparing payload/receipt/replay output.