refactor(interop): move log helpers into op-core/interop/messages#20946
Queued
ajsutton wants to merge 1 commit into
Queued
refactor(interop): move log helpers into op-core/interop/messages#20946ajsutton wants to merge 1 commit into
ajsutton wants to merge 1 commit into
Conversation
Moves MessageFromLog, DecodeExecutingMessageLog, and LogToLogHash out of op-supervisor/supervisor/backend/processors and into op-core/interop/messages. These functions are pure log-decoding helpers that operate entirely on op-core/interop/messages types; they have no coupling to supervisor backend state. Several non-supervisor consumers (op-interop-filter, op-interop-mon, op-supernode, op-program) were reaching into the supervisor processors package just for these helpers. After this change there are no external imports of op-supervisor/supervisor/backend/processors. The processors package remains as the supervisor's internal log-ingestion pipeline (chain_processor, log_processor, client) and consumes the helpers via op-core/interop/messages alongside the rest of its callers. EventDecoderFn is consolidated into log_processor.go since it is only used there.
wwared
approved these changes
May 21, 2026
Any commits made after this event will not be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
MessageFromLog,DecodeExecutingMessageLog, andLogToLogHashout ofop-supervisor/supervisor/backend/processorsand intoop-core/interop/messages. These are pure log-decoding helpers overop-core/interop/messagestypes with no coupling to supervisor backend state.After this change there are no external imports of
op-supervisor/supervisor/backend/processors—op-interop-filter,op-interop-mon,op-supernode, andop-programnow reach the helpers viaop-core/interop/messagesalongside the rest of the interop vocabulary. The processors package remains as the supervisor's internal log-ingestion pipeline (chain_processor,log_processor,client) and consumes the helpers like any other caller.EventDecoderFnis consolidated intolog_processor.gosince that's the only file that uses it.A small step in the larger op-supervisor removal effort, alongside #20896.