supernode: harden direct rewind around op-reth restart#20962
Draft
karlfloersch wants to merge 1 commit into
Draft
supernode: harden direct rewind around op-reth restart#20962karlfloersch wants to merge 1 commit into
karlfloersch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Draft follow-up to #20956. This tries the simplest CL/supernode-side recovery hardening for the op-reth proofs-history reorg repro:
VirtualNode.Stopwait until the embedded op-node has actually stopped beforeRewindEnginerewinds the ELBlockAtTimestampon the chain-container engine-controller interface so the chain container can resolve that SafeDB targetLocal result
This does not fully recover the repro yet. It improves the sequence enough that, after the first op-reth restart, chain 901 is driven forward again, but op-reth then crashes a second time from the proofs-history ExEx while ingesting the replacement chain. That suggests the remaining failure is still in EL/ExEx state handling, not just supernode reset bookkeeping.
Relevant local acceptance run:
Important signals from
/tmp/op-reth-reorg-recovery-attempt.log:chain_container/RewindEngine: rewound safe-db target=415c48..f9f0b7:14ExEx proofs-history crashed: Attempted to unwind to block 14 beyond earliest stored block 20restarting op-reth after proofs-history unwind exitUnsafeL2 ... :27, withPendingSafeL2/LocalSafeL2 ... :15ExEx proofs-history crashed: Parent hash mismatch at block 22repro observedTests
go test ./op-supernode/supernode/chain_container/...go test ./op-supernode/supernode/activity/interop -run 'TestApplyPendingTransition|TestReset|TestRewind'