supernode: try native engine reset for invalidation rewinds#20964
Draft
karlfloersch wants to merge 1 commit into
Draft
supernode: try native engine reset for invalidation rewinds#20964karlfloersch wants to merge 1 commit into
karlfloersch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Experimental recovery branch on top of
karl/op-reth-reorg-repro. Instead of manually rewinding the EL and recreating the virtual node, invalidation rewinds now route through the op-node engine reset path.Changes:
ForceEngineResetentrypoint that runsEngineController.ForceReseton the driver event loopChainContainer.RewindEngineto compute reset targets and issue the native resetLocal Validation
Passing: