Make the second head_v2 emission on empty->full a "should" - #628
Merged
Conversation
syjn99
approved these changes
Jul 17, 2026
nflaig
pushed a commit
that referenced
this pull request
Jul 28, 2026
Follow up to #628; On the [thread](https://discord.com/channels/595666850260713488/1525035809890107492) we also discussed the behavior occurring on edge-cases (ex. payload status change from full to empty) and mentioned that it can be implementation specific. It might be useful to have this one sentence, that notes what is currently implied (not enforcing emissions on edge case payload status changes). It can also serve as a reminder to revisit this topic later on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the
head_v2second emission description onempty->fullpayload status change frommaytoshould, so consumers can rely on receiving it. Emission onfull->emptystays optional/implementation-defined.Discord discussion thread; Follow up to #590