Guard get_parent_payload_status at fork boundary#5125
Open
AbolareRoheemah wants to merge 1 commit intoethereum:masterfrom
Open
Guard get_parent_payload_status at fork boundary#5125AbolareRoheemah wants to merge 1 commit intoethereum:masterfrom
get_parent_payload_status at fork boundary#5125AbolareRoheemah wants to merge 1 commit intoethereum:masterfrom
Conversation
Member
|
Please review the proposed fix, it breaks post Gloas forks as it can be seen in the failed action: |
jtraglia
changed the title
get_parent_payload_status at fork boundary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_parent_payload_status(and thereforeis_parent_node_full) was unconditionally accessing the Gloas-only fieldparent.body.signed_execution_payload_bideven for pre-Gloas blocks.This PR adds a guard that checks
parent_state.fork.current_versionand treats any pre-Gloas parent asPAYLOAD_STATUS_PENDING(matching the behavior Lighthouse already implements).No changes were needed to
on_blockoris_parent_node_full.All Gloas tests pass with
make test fork=gloas.Fixes #5096