Add test for checking builder index reuse#5296
Merged
jtraglia merged 2 commits intoMay 28, 2026
Merged
Conversation
pawanjay176
changed the title
jtraglia
approved these changes
May 27, 2026
Member
jtraglia
left a comment
jtraglia
left a comment
There was a problem hiding this comment.
Nice, this looks great. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new test for gloas parent execution payload processing.
The test covers a same-batch builder deposit edge case where a reusable zero-balance builder slot is first topped up, then followed by a new builder deposit. The expected behavior is that the topped-up builder keeps its slot and the new builder is assigned a different index.
To be clear, this is not an issue with a spec. Its a potential regression that can happen when optimising the
process_deposit_requestpath.Found this edge case when optimising builder deposits verification in lighthouse. See sigp/lighthouse#9311 (comment)
Confirmed that the test was failing before the fix in lighthouse and passes after the fix.