refactor: redundancy getter exhaust#5470
Merged
Merged
Conversation
gacevicljubisa
approved these changes
May 21, 2026
martinconic
approved these changes
May 21, 2026
acud
approved these changes
May 28, 2026
| // errGetterExhausted is returned when the retry loop exhausts all levels without | ||
| // receiving a result or enough errors to trigger ErrSwarmageddon. | ||
| // This path should never be reached under normal operation. | ||
| errGetterExhausted = errors.New("replicas getter: exhausted all levels without result (unexpected)") |
Contributor
There was a problem hiding this comment.
similar comment to the other PR - this also suggests incorrect error handling. not a big fan of this but approving because this package's legibility is limited for me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small cleanup of
pkg/replicas/getter.goprompted by a beekeeper CI failure where thereturn nil, nilat the bottom ofGetwas somehow reached, causing a nil-panic downstream injoiner.New.Changes:
NONEshort-circuit:NewGetterwithredundancy.NONEnow returnsg.Getter.Getdirectly. The replica machinery (goroutines, ticker, replicator) is pointless for level 0, and emittingErrSwarmageddonwhen the chunk is simply not found at level 0 was semantically wrong.return nil, nil→errGetterExhausted: the trailing return is structurally unreachable (the replicator exhausts exactly at the last loop iteration, turning it into an indefinite wait onresultC/errc; the loop always exits via success or Swarmageddon). Renamed to a named sentinel with a matching comment so the intent is clear if it ever surfaces again.level=0all-fail case no longer assertsErrSwarmageddon; the raw error is returned via the short-circuit.