add --serve-all to disable classification and serve every peer - #42
Open
cskiraly wants to merge 1 commit into
Open
add --serve-all to disable classification and serve every peer#42cskiraly wants to merge 1 commit into
cskiraly wants to merge 1 commit into
Conversation
Adds an opt-in rendezvous mode. With --serve-all the bootnode skips EL/CL classification and fork-ID/digest filtering entirely: every discovered node is pooled into every enabled table (regardless of eth/eth2 fields) and served to every requester. Turns bootnodoor into a plain discv5 rendezvous, like a stock geth bootnode. Default off; classification + fork filtering unchanged.
cskiraly
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an opt-in rendezvous mode without filters. With --serve-all the bootnode skips EL/CL classification and fork-ID/digest filtering entirely: every discovered node is pooled into every enabled table (regardless of eth/eth2 fields) and served to every requester. Turns bootnodoor into a plain discv5 rendezvous, like a stock geth bootnode. Default off; classification + fork filtering unchanged.
This might feel counterintuitive, but the filtering is not required by the protocol, and that part of the code can actually lead to various issues (see e.g. #41). Being able to turn it off helps diagnosis.