fix: only apply beaconapi.clientIndex filter when explicitly set#651
Closed
barnabasbusa wants to merge 1 commit intoethpandaops:masterfrom
Closed
fix: only apply beaconapi.clientIndex filter when explicitly set#651barnabasbusa wants to merge 1 commit intoethpandaops:masterfrom
barnabasbusa wants to merge 1 commit intoethpandaops:masterfrom
Conversation
ClientIndex was a plain `int` whose zero value (0) caused ReadConfig to collapse `beaconapi.endpoints` down to `endpoints[0]` whenever the field was omitted from the config. Users with multiple beacon endpoints only ever saw the first one on the consensus clients page and in the indexer. Change ClientIndex to `*int` so that only explicit configuration (YAML or env) triggers the single-endpoint selection.
Collaborator
Author
|
reopening from origin with correct branch prefix (bbusa/) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
beaconapi.ClientIndexwas typedint, so its Go zero value (0) always satisfied the>= 0check inutils.ReadConfig, collapsingbeaconapi.endpointsdown toendpoints[0]for users who never setclientIndex. Multi-endpoint setups only ever exposed the first beacon client on/clients/consensusand in the indexer.ClientIndexto*intsonilmeans "unset"; the single-endpoint selection now only runs when the field is explicitly configured (YAML orBEACONAPI_CLIENT_INDEX).Test plan
beaconapi.endpointsand noclientIndexpreviously rendered only the first client on/clients/consensus; after the fix, both clients are listed and indexed.go build ./...passes.clientIndex: N(selects a single endpoint) andBEACONAPI_CLIENT_INDEXenv var.