log: raise BAL decode failures to error level#653
Open
barnabasbusa wants to merge 1 commit intomasterfrom
Open
log: raise BAL decode failures to error level#653barnabasbusa wants to merge 1 commit intomasterfrom
barnabasbusa wants to merge 1 commit intomasterfrom
Conversation
BAL decode errors were logged at warn level, which made them easy to miss when investigating why slot pages were silently dropping the BAL section. Bump both the slot handler and the blockdb-backed fallback in ChainService to error so format regressions (e.g. across EIP-7928 spec churn) surface clearly in production logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handlers/slot.goandservices/chainservice_blocks.gowere logged atwarnlevel, so when the slot view silently dropped the Block Access List section (e.g. after a geth upgrade across EIP-7928 spec churn) there was no obvious signal in the logs.errorso format regressions surface immediately in production logs. No behavioural change beyond log level.Test plan
go build ./...(passes locally)level=errorin the logs.