Skip to content

feat(discord/build): add pr option to auto-detect repo & ref#153

Merged
mattevans merged 2 commits intomasterfrom
feat/build-pr-option
Apr 22, 2026
Merged

feat(discord/build): add pr option to auto-detect repo & ref#153
mattevans merged 2 commits intomasterfrom
feat/build-pr-option

Conversation

@barnabasbusa
Copy link
Copy Markdown
Contributor

Summary

  • New pr option on /build client-cl and /build client-el (after client) that takes a GitHub PR URL, owner/repo#N shorthand, or bare PR number.
  • Resolver calls the GitHub Pulls API and overrides repository / ref with the PR's head.repo.full_name and head.ref, so builds work for forks and feature branches without looking either up manually.
  • Bare numbers fall back to the client workflow's default repo; full URLs / shorthand work for any repo (incl. forks).

Test plan

  • /build client-cl client:lighthouse pr:https://github.com/sigp/lighthouse/pull/<N> builds against the PR's head repo/branch
  • /build client-el client:geth pr:ethereum/go-ethereum#<N> resolves via shorthand
  • /build client-cl client:prysm pr:<bare-number> falls back to the client's upstream repo
  • PR from a fork resolves to the fork's full_name (not the upstream)
  • Invalid PR URL surfaces a clean ephemeral error without breaking the interaction
  • Existing flows (no pr, explicit repository / ref) behave unchanged

Accepts a GitHub PR URL, owner/repo#N shorthand, or bare number on
/build client-cl and /build client-el. Resolves via the GitHub Pulls
API and overrides repository/ref with the PR's head, so builds work
for forks and feature branches without having to look up either.
@barnabasbusa barnabasbusa requested a review from mattevans as a code owner April 21, 2026 08:54
@mattevans
Copy link
Copy Markdown
Member

Seems to work: https://github.com/ethpandaops/eth-client-docker-image-builder/actions/runs/24755271849

Screenshot 2026-04-22 at 11 25 16 Screenshot 2026-04-22 at 11 25 45

Merging and will cut a release

@mattevans mattevans merged commit 85574f3 into master Apr 22, 2026
4 checks passed
@mattevans mattevans deleted the feat/build-pr-option branch April 22, 2026 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants