consumoor: remove kzg_commitments array from data column sidecar#805
Merged
Savid merged 1 commit intorelease/consumoorfrom Apr 10, 2026
Merged
Conversation
The kzg_commitments Array(FixedString(98)) column is redundant since kzg_commitments_count already captures the needed information. This removes the column from the ClickHouse migration and strips the corresponding field, serialization, reset, and snapshot logic from the beacon consumoor route. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mattevans
approved these changes
Apr 8, 2026
samcm
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kzg_commitments Array(FixedString(98))column from thebeacon_api_eth_v1_events_data_column_sidecar_localClickHouse migration, as the data is redundant with the existingkzg_commitments_countfieldbeacon_api_eth_v1_events_data_column_sidecar.gen.go) to remove theKzgCommitmentsstruct field, constructor initialization,Input()entry,Reset()call,Snapshot()row, and adjusts the map capacity from 30 to 29GetKzgCommitments()append logic frombeacon_api_eth_v1_events_data_column_sidecar.gothat serialized the commitments array into the batchThe libp2p
gossipsub_data_column_sidecarroute was already correct — it only hadKzgCommitmentsCount, no array field.Note:
deploy/local/docker-compose/vector-kafka-clickhouse.yaml:657still references.kzg_commitmentsin thebeacon_api_eth_v1_events_blob_sidecar_formattedsink (which also takes data_column_sidecar input). This may need a separate update if that sink feeds the same table.Test plan
go build ./pkg/consumoor/...compiles cleanlygolangci-lintpasses on changed fileskzg_commitmentscolumn🤖 Generated with Claude Code