Actually support large contracts#2
Merged
RogerPodacter merged 1 commit intoethscriptionsfrom Nov 4, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the miner to use a configurable EVM configuration instead of a hardcoded empty vm.Config{}, ensuring consistency between block building and block validation. This addresses potential gas accounting discrepancies that could arise from using different EVM configurations during these two operations.
- Added
evmConfigfield to theMinerstruct to store the EVM execution configuration - Updated
miner.New()constructor to accept and initialize theevmConfigparameter - Replaced hardcoded
vm.Config{}instances inprepareWorkandapplyTransactionwith the configuredminer.evmConfig
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| miner/miner.go | Added evmConfig field to Miner struct and updated New() constructor to accept and store the EVM configuration |
| miner/worker.go | Replaced empty vm.Config{} with miner.evmConfig in prepareWork and applyTransaction methods |
| eth/backend.go | Updated miner.New() call to pass the vmConfig used for blockchain initialization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Plumbs a configured
vm.Config(e.g., NoMaxCodeSize) into the miner and uses it for EVM execution during payload building for consistency with validation.eth/backend.go)vm.Config(preimage/witness/tracer,NoMaxCodeSize) and passes it intominer.New.miner/miner.go,miner/worker.go)evmConfigtoMiner; updates constructor to accept it.evmConfigwhen creating the EVM and applying transactions, aligning payload building with block validation (incl. beacon root processing).Written by Cursor Bugbot for commit a4f5363. This will update automatically on new commits. Configure here.