Remove legacy word-domains protocol support and associated parser#148
Merged
RogerPodacter merged 1 commit intoevm-backend-demofrom Nov 24, 2025
Merged
Remove legacy word-domains protocol support and associated parser#148RogerPodacter merged 1 commit intoevm-backend-demofrom
RogerPodacter merged 1 commit intoevm-backend-demofrom
Conversation
- Deleted the `WordDomainsParser` class and its references from the `ProtocolParser`, streamlining protocol handling. - Removed the `name_registry` contract and its related tests, eliminating legacy word-domain registration functionality. - Updated the `L2Genesis` contract to exclude the `NameRegistry` from proxied contract checks and registration. - Adjusted tests to reflect the removal of word-domains, ensuring consistency across the codebase.
There was a problem hiding this comment.
Pull request overview
This PR cleanly removes the legacy word-domains protocol support from the codebase, eliminating unused functionality and simplifying the protocol handling architecture. The changes span both Ruby application code and Solidity smart contracts, ensuring complete removal of the deprecated feature.
Key changes:
- Removed the
WordDomainsParserclass and its associated test suite - Deleted the
NameRegistrySolidity contract and its tests, which handled word-domain registrations as ERC-721 tokens - Updated the
ProtocolParserto remove word-domains routing and the special case handling for plain text registrations
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
spec/models/word_domains_parser_spec.rb |
Deleted comprehensive test suite for WordDomainsParser functionality |
spec/models/protocol_parser_spec.rb |
Removed word-domains specific test cases from protocol parser tests |
spec/models/erc721_ethscriptions_collection_parser_spec.rb |
Removed obsolete comment about 'data:,null' being a valid word-domains registration |
contracts/test/NameRegistry.t.sol |
Deleted test suite covering registration, primary name setting, and transfer mirroring |
contracts/src/libraries/Predeploys.sol |
Removed NAME_REGISTRY constant (address 0x3300...0007) |
contracts/src/NameRegistry.sol |
Deleted entire NameRegistry contract implementation |
contracts/script/L2Genesis.s.sol |
Removed NameRegistry from proxied contracts check, implementation setup, and protocol handler registration |
app/models/word_domains_parser.rb |
Deleted parser class that validated and encoded word-domain operations |
app/models/protocol_parser.rb |
Removed word-domains from protocol parser mapping and deleted try_plain_word_domains fallback method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WordDomainsParserclass and its references from theProtocolParser, streamlining protocol handling.name_registrycontract and its related tests, eliminating legacy word-domain registration functionality.L2Genesiscontract to exclude theNameRegistryfrom proxied contract checks and registration.Note
Removes all word-domains support (parser, contract, predeploy, registration) and updates parsers, genesis script, and tests accordingly.
word-domainssupport: deleteWordDomainsParser; drop mapping and plain-text fallback inProtocolParser.ProtocolParser.extract/for_calldata: unchanged for supported protocols; returnsnil/default for non-protocol data.contracts/src/NameRegistry.soland its tests; remove related imports/usages.Predeploys.NAME_REGISTRYconstant.L2Genesis.s.sol:word-domainshandler; only register ERC-20 fixed denomination and ERC-721 collection handlers.Written by Cursor Bugbot for commit 2a0b6ee. This will update automatically on new commits. Configure here.