Remove unused ERC20NullOwnerCappedUpgradeable contract and simplify t…#149
Merged
RogerPodacter merged 1 commit intoevm-backend-demofrom Nov 24, 2025
Merged
Remove unused ERC20NullOwnerCappedUpgradeable contract and simplify t…#149RogerPodacter merged 1 commit intoevm-backend-demofrom
RogerPodacter merged 1 commit intoevm-backend-demofrom
Conversation
…okenURI function in ERC20FixedDenomination contract. The tokenURI function no longer validates token IDs, streamlining its implementation.
There was a problem hiding this comment.
Pull request overview
This PR removes an unused contract and simplifies the tokenURI function by eliminating redundant validation. The removal of ERC20NullOwnerCappedUpgradeable.sol is safe as the contract is not referenced anywhere in the codebase. The tokenURI simplification is correct since ownerOf() already performs token ID validation internally.
- Removed unused
ERC20NullOwnerCappedUpgradeable.solcontract (189 lines) - Simplified
tokenURIby removing redundant_validateTokenIdcall
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
contracts/src/ERC20NullOwnerCappedUpgradeable.sol |
Complete removal of unused ERC20 contract with capping and null-owner support |
contracts/src/ERC20FixedDenomination.sol |
Removed redundant _validateTokenId call in tokenURI since ownerOf already validates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…okenURI function in ERC20FixedDenomination contract. The tokenURI function no longer validates token IDs, streamlining its implementation.
Note
Removes unused ERC20NullOwnerCappedUpgradeable and streamlines ERC20FixedDenomination.tokenURI by dropping redundant token ID validation.
ERC20FixedDenomination: SimplifiestokenURI(uint256)by removing redundant token ID validation (relies onownerOfto revert for invalid IDs).contracts/src/ERC20NullOwnerCappedUpgradeable.sol.Written by Cursor Bugbot for commit 7bb3566. This will update automatically on new commits. Configure here.