Skip to content

Add use_non_matching_label option#518

Merged
AngheloAlf merged 2 commits intoethteck:mainfrom
inspectredc:use-non-matching-label
Feb 28, 2026
Merged

Add use_non_matching_label option#518
AngheloAlf merged 2 commits intoethteck:mainfrom
inspectredc:use-non-matching-label

Conversation

@inspectredc
Copy link
Copy Markdown
Contributor

Adds splat support for the spimdisasm option added in this PR Decompollaborate/spimdisasm#199

Please let me know if I need to update any sections of the documentation to accompany this change

Copy link
Copy Markdown
Collaborator

@AngheloAlf AngheloAlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to mention the new attribute here https://github.com/ethteck/splat/blob/main/docs/Adding-Symbols.md

You also need to bump the min spimdisasm version to 1.40.0. It is defined in a few places like pyproject.toml, requirements.txt and
https://github.com/ethteck/splat/blob/main/src/splat/disassembler/spimdisasm_disassembler.py#L10, and maybe something else I'm missing.

@inspectredc
Copy link
Copy Markdown
Contributor Author

Have updated the relevant sections now, sorry for the delay!

@AngheloAlf AngheloAlf merged commit cf82fc9 into ethteck:main Feb 28, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants