Add option for generating -include directives in dependency file#531
Open
ser-pounce wants to merge 5 commits intoethteck:mainfrom
Open
Add option for generating -include directives in dependency file#531ser-pounce wants to merge 5 commits intoethteck:mainfrom
-include directives in dependency file#531ser-pounce wants to merge 5 commits intoethteck:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new convenience option that adds an
-includedirective to the generatedlink.dfile, which will naively attempt to load one additional dependency file for each .o file in the .elf dependencies.The soft fail is necessary as the dependencies might not exist at the time of import, e.g. before the first toolchain pass.
I suppose ideally the exact path should be configurable to account for dependencies that don't live next to their object file, but maybe that can be implemented later if the need arises.
I'm not completely sure that deduplicating the .elf dependencies specifically is safe because I'm not familiar with using splat with anything except object files, that part can be dropped if necessary.