This repository was archived by the owner on Dec 18, 2019. It is now read-only.
Open
Conversation
|
While this does add binary support, it breaks compatibility with Ruby 1.8.7. |
Contributor
|
@stephas Awesome, thanks for the PR. mctop hasn't seen an activity in about a year, but that is about to change. After that is done I am going to start adding binary support to mctop. After all the merging and other work I don't know how well this patch will land. Either way I would love your help in the near future. |
|
I confirm that it works on Ruby 1.9.2 and Memcached 1.4.17 on Centos 5. But I had to also apply this #24 to make it work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this should give mctop binary protocol support.
thank you etsy.