Skip to content
This repository was archived by the owner on Dec 18, 2019. It is now read-only.

first rev with binary protocol support#20

Open
stephas wants to merge 1 commit intoetsy:masterfrom
stephas:master
Open

first rev with binary protocol support#20
stephas wants to merge 1 commit intoetsy:masterfrom
stephas:master

Conversation

@stephas
Copy link

@stephas stephas commented Apr 24, 2014

this should give mctop binary protocol support.

  • will dynamically decide if the packet is binary or ascii protocol
  • first rev filters opcode 1, e.g. set to extract keys
  • also replaces unprintable characters with '~'

thank you etsy.

@scurvy
Copy link

scurvy commented May 8, 2014

While this does add binary support, it breaks compatibility with Ruby 1.8.7.

@Sean-Der
Copy link
Contributor

@stephas Awesome, thanks for the PR.

mctop hasn't seen an activity in about a year, but that is about to change.
I am going to go through and review all the smaller feature PRs, merge those and tag a release.

After that is done I am going to start adding binary support to mctop. After all the merging and other work I don't know how well this patch will land. Either way I would love your help in the near future.

@gdubicki
Copy link

I confirm that it works on Ruby 1.9.2 and Memcached 1.4.17 on Centos 5. But I had to also apply this #24 to make it work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants