fix: declare MINIMERCH_ADDRESS and dbReady in service.js#21
Merged
Conversation
service.js runs in an isolated ServiceJSRunner thread — it does not share scope with app.js. Both variables were commented out with a note saying they were declared in app.js, causing a ReferenceError every 10 seconds on MDS_TIMER_10SECONDS. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
service.jsruns in an isolated MinimaServiceJSRunnerthread — it does not share scope withapp.jsMINIMERCH_ADDRESSanddbReadywere commented out with notes saying "declared in app.js", causingReferenceError: MINIMERCH_ADDRESS is not definedon line 204 every 10 seconds (everyMDS_TIMER_10SECONDStick)service.js's own scopeTest plan
miniMerchInbox.mds.zipon the vendor nodeSERVICEJS_POLLerrors are gone from the node logs🤖 Generated with Claude Code