Skip to content

Improve Langfuse Adapter#181

Merged
xzrderek merged 2 commits into
mainfrom
derekx/update-langfuse-adapter
Sep 16, 2025
Merged

Improve Langfuse Adapter#181
xzrderek merged 2 commits into
mainfrom
derekx/update-langfuse-adapter

Conversation

@xzrderek

@xzrderek xzrderek commented Sep 16, 2025

Copy link
Copy Markdown
Contributor

here's an example of the new pattern

def custom_converter(trace: TraceWithFullDetails, include_tool_calls: bool, span_name: Optional[str]) -> Optional[EvaluationRow]:
    messages = []

    if span_name:  # Look for a generation tied to a span name
        try:
            gen = find_final_generation_in_span(trace, span_name)
            if not gen:
                return None

            tools = []

            if gen.input:
                for d in gen.input:
                    if d["role"] == "tool":
                        tools.append(d["content"])
                    else:
                        messages.append(dict_to_message(d, include_tool_calls))
            if gen.output:
                messages.append(dict_to_message(gen.output, include_tool_calls))
            
            return EvaluationRow(
                messages=messages,
                tools=tools,
                input_metadata=InputMetadata(
                    session_data={
                        "langfuse_trace_id": trace.id,  # Store the trace ID here
                    }
                ),
            )
            
        except Exception as e:
            logger.error("Failed to extract messages from span '%s' in trace %s: %s", span_name, trace.id, e)
            return None
    else:
        logger.error("No span name provided")
        return None

@pytest.mark.asyncio
@evaluation_test(
    input_rows=[
        adapter.get_evaluation_rows(
            name="Subagent 1",
            limit=3,
            span_name="judge",
            environment="production",
            converter=custom_converter,
        )

@xzrderek xzrderek changed the title Updated Langfuse Improve Langfuse Adapter Sep 16, 2025
Comment thread eval_protocol/adapters/langfuse.py Outdated
sleep_between_gets: float = 2.5,
max_retries: int = 3,
span_name: Optional[str] = None,
converter: Optional[Callable[[TraceWithFullDetails, bool, Optional[str]], Optional[EvaluationRow]]] = None,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: make this a protocol

@dphuang2 dphuang2 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit but LGTM

@xzrderek xzrderek merged commit 0d11ed8 into main Sep 16, 2025
1 check passed
@xzrderek xzrderek deleted the derekx/update-langfuse-adapter branch September 16, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants