Conversation
PR SummaryLow Risk Overview Introduces a miniredis-backed unit test that exercises Reviewed by Cursor Bugbot for commit bca977c. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before autofix could start.
Reviewed by Cursor Bugbot for commit bca977c. Configure here.
| }) | ||
| if err := instrumentDefaultRedisClient(client); err != nil { | ||
| return nil, nil, nil, nil, err | ||
| } |
There was a problem hiding this comment.
Redis client leaked on instrumentation error path
Low Severity
If instrumentDefaultRedisClient returns an error, newRuntimeStore returns without closing the newly created client. The Close function is only returned to the caller on the success path (line 478), so this error path leaks the Redis client. Adding client.Close() before returning the error would ensure cleanup.
Reviewed by Cursor Bugbot for commit bca977c. Configure here.


Summary
Testing