You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Medium Risk
Touches core session/grant state transitions and cleanup paths; while behavior changes are limited to metrics side effects, incorrect transition accounting could skew observability or cause Prometheus registration conflicts.
Overview
Adds Prometheus domain metrics for ASB session/grant/approval lifecycles, including sessions_active (by tenant), sessions_total and grants_total (by outcome), plus histograms for grant_ttl_seconds and approval_wait_seconds.
Wires metrics into the app Service and lifecycle paths (create, issue, approve/deny/expire, revoke, cleanup expiry) so transitions increment counters and maintain the active-session gauge, and registers the collectors during bootstrap so they appear on the existing /metrics endpoint. Includes Prometheus-backed tests covering create+issue, approval flow, revoke, and cleanup expiry.
Reviewed by Cursor Bugbot for commit ff8b9a2. Bugbot is set up for automated code reviews on this repo. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/metricsendpointTesting