You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary\n- add active artifact gauges by connector kind and unwrap counters by connector kind\n- update grant, unwrap, revoke, and cleanup flows to keep artifact gauges accurate\n- extend metrics tests to cover artifact issuance, unwraps, and artifact teardown transitions\n\n## Testing\n- go test ./internal/app\n- go test ./internal/bootstrap ./cmd/asb-api ./internal/api/httpapi ./internal/worker\n- go test ./...\n- git diff --check\n
Low Risk
Low risk: changes are limited to Prometheus instrumentation, adding new collectors and updating a few lifecycle paths to keep gauge counts consistent.
Overview
Adds Prometheus metrics for artifact lifecycle visibility: a new *_artifacts_active gauge (labeled by connector_kind) and a new *_artifact_unwraps_total counter.
Wires these metrics into artifact issuance (issueGrant), artifact use (UnwrapArtifact), grant revoke/expire transitions, and cleanup-driven artifact expiration so the active-artifact gauge decrements/ increments based on ArtifactState transitions.
Extends metrics_test.go to assert artifact gauge updates on issuance and teardown, and adds coverage for unwrap counting and active-artifact decrements on unwrap.
Reviewed by Cursor Bugbot for commit 253fe87. Bugbot is set up for automated code reviews on this repo. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- add active artifact gauges by connector kind and unwrap counters by connector kind\n- update grant, unwrap, revoke, and cleanup flows to keep artifact gauges accurate\n- extend metrics tests to cover artifact issuance, unwraps, and artifact teardown transitions\n\n## Testing\n- go test ./internal/app\n- go test ./internal/bootstrap ./cmd/asb-api ./internal/api/httpapi ./internal/worker\n- go test ./...\n- git diff --check\n