Skip to content

Instrument connector metrics#42

Merged
haasonsaas merged 1 commit intomainfrom
jonathanhaas/connector-metrics
Apr 14, 2026
Merged

Instrument connector metrics#42
haasonsaas merged 1 commit intomainfrom
jonathanhaas/connector-metrics

Conversation

@haasonsaas
Copy link
Copy Markdown
Collaborator

Summary\n- add connector operation counters and latency histograms in ASB metrics\n- record connector issue, revoke, and GitHub proxy execution operations by connector kind\n- extend metrics tests to cover issue, revoke, and proxy execution instrumentation\n\n## Testing\n- go test ./internal/app\n- go test ./internal/bootstrap ./cmd/asb-api ./internal/api/httpapi ./internal/worker\n- go test ./...\n- git diff --check\n

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 14, 2026

PR Summary

Low Risk
Low risk observability-only change; it adds Prometheus metrics and lightweight timing around connector Issue, Revoke, and GitHub proxy execution without changing business logic.

Overview
Adds new Prometheus metrics to track connector operation volume and latency: *_connector_operations_total (labeled by connector_kind, operation, outcome) and *_connector_operation_seconds (labeled by connector_kind, operation).

Instruments connector calls to record these metrics for grant issue, grant revoke during cleanup/state transitions, and ExecuteGitHubProxy operations. Updates metrics tests to assert the new counters/histogram observations, including a new proxy execution test.

Reviewed by Cursor Bugbot for commit 3088707. Bugbot is set up for automated code reviews on this repo. Configure here.

@haasonsaas haasonsaas merged commit 9bdf788 into main Apr 14, 2026
4 checks passed
@haasonsaas haasonsaas deleted the jonathanhaas/connector-metrics branch April 14, 2026 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant