You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary\n- add connector operation counters and latency histograms in ASB metrics\n- record connector issue, revoke, and GitHub proxy execution operations by connector kind\n- extend metrics tests to cover issue, revoke, and proxy execution instrumentation\n\n## Testing\n- go test ./internal/app\n- go test ./internal/bootstrap ./cmd/asb-api ./internal/api/httpapi ./internal/worker\n- go test ./...\n- git diff --check\n
Low Risk
Low risk observability-only change; it adds Prometheus metrics and lightweight timing around connector Issue, Revoke, and GitHub proxy execution without changing business logic.
Overview
Adds new Prometheus metrics to track connector operation volume and latency: *_connector_operations_total (labeled by connector_kind, operation, outcome) and *_connector_operation_seconds (labeled by connector_kind, operation).
Instruments connector calls to record these metrics for grant issue, grant revoke during cleanup/state transitions, and ExecuteGitHubProxy operations. Updates metrics tests to assert the new counters/histogram observations, including a new proxy execution test.
Reviewed by Cursor Bugbot for commit 3088707. Bugbot is set up for automated code reviews on this repo. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- add connector operation counters and latency histograms in ASB metrics\n- record connector issue, revoke, and GitHub proxy execution operations by connector kind\n- extend metrics tests to cover issue, revoke, and proxy execution instrumentation\n\n## Testing\n- go test ./internal/app\n- go test ./internal/bootstrap ./cmd/asb-api ./internal/api/httpapi ./internal/worker\n- go test ./...\n- git diff --check\n