Conversation
PR SummaryMedium Risk Overview Updates Reviewed by Cursor Bugbot for commit ef4f60c. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before autofix could start.
Reviewed by Cursor Bugbot for commit ef4f60c. Configure here.
| return existing, nil | ||
| } | ||
| return collector, nil | ||
| } |
There was a problem hiding this comment.
Three helper functions fully duplicated across packages
Low Severity
metricsPrefix, registerCounterVec, and registerHistogram are verbatim copies of the identical unexported functions already in internal/app/metrics.go. Any future bug fix to one copy risks being missed in the other. These could live in a shared internal package (e.g. internal/promutil) to eliminate the duplication.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit ef4f60c. Configure here.


Summary\n- add cleanup pass counters and duration histograms in the worker package\n- record cleanup stats on every successful worker pass\n- expose an optional worker endpoint via or \n\n## Testing\n- go test ./internal/worker ./cmd/asb-worker\n- go test ./internal/bootstrap ./cmd/asb-api ./internal/api/httpapi ./internal/app\n- go test ./...\n- git diff --check\n