This repository was archived by the owner on Apr 16, 2026. It is now read-only.
Merged
Conversation
PR SummaryLow Risk Overview Tests now assert Reviewed by Cursor Bugbot for commit 8db8cff. Bugbot is set up for automated code reviews on this repo. Configure here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toolregistrypackage tests for required-field validation, not-found lookups, overwrite behavior, and returned-copy semanticsinternal/appWhy
asb#61still called out the lack of directtoolregistryunit tests. This keeps that gap small and reviewable without mixing in the larger durable-audit or Helm work.Validation
go test ./internal/authz/toolregistry -count=1go test ./... -count=1GOTOOLCHAIN=go1.26.0 go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.11.3 run ./internal/authz/toolregistry ./internal/appgit diff --checkScope
This is a second bounded slice of
asb#61, limited to directtoolregistryunit coverage.