[codex] identity/v1: add agent_id to IssueAgentTokenRequest#54
[codex] identity/v1: add agent_id to IssueAgentTokenRequest#54haasonsaas merged 3 commits intomainfrom
Conversation
PR SummaryMedium Risk Overview Marks Reviewed by Cursor Bugbot for commit a42cda9. Bugbot is set up for automated code reviews on this repo. Configure here. |
ReviewThis is the right direction — Looks good
QuestionWhat happens when both
This precedence should be documented in the proto field comments so all implementations agree. |
Clarify that agent_id takes precedence when set, and that the deprecated agent_type/capabilities fields are only accepted for backward compat when agent_id is empty. Addresses PR review feedback. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
agent_idtoidentity.v1.IssueAgentTokenRequestagent_typeandcapabilitiesas deprecated instead of removing them outrightWhy
evalops/identity#70needsIssueAgentTokento validate an existing agent record in registry and deriveagent_typepluscapabilitiesfrom that record. The current proto request cannot express that because it does not carry an agent identifier.Adding
agent_idas a new field keeps wire compatibility while allowing identity to enforce the registry-backed lookup.Validation
buf generatenpm run check:packageRelated: evalops/identity#70