Skip to content

Add attribution service contract#76

Merged
haasonsaas merged 1 commit intomainfrom
codex/attribution-proto-bootstrap
Apr 15, 2026
Merged

Add attribution service contract#76
haasonsaas merged 1 commit intomainfrom
codex/attribution-proto-bootstrap

Conversation

@haasonsaas
Copy link
Copy Markdown
Contributor

Summary\n- add the initial attribution.v1 service contract for persisted deal attribution reports and export\n- generate Go, Python, and TypeScript artifacts plus package exports\n- extend proto CI smoke coverage to include the new package\n\n## Validation\n- buf lint --path proto/attribution/v1/attribution.proto\n- buf generate --path proto/attribution/v1/attribution.proto --timeout 10m\n- go test ./... -count=1\n- actionlint .github/workflows/ci.yml\n- npm ci && npm run check:package

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 15, 2026

PR Summary

Low Risk
Low risk: this PR primarily adds a new protobuf API surface and generated client artifacts, with only small updates to CI and package exports.

Overview
Adds a new attribution.v1 protobuf service contract for generating, retrieving, and exporting persisted attribution reports, including schemas for deal context, trace/usage touchpoints, and agent/team ROI rollups.

Checks in regenerated Go/Connect, Python, and TypeScript artifacts for the new API, updates package.json exports to publish the TS module, adds RPC descriptions to descriptions.yaml, and extends CI’s Python wheel smoke test to import AttributionReport.

Reviewed by Cursor Bugbot for commit 292636f. Bugbot is set up for automated code reviews on this repo. Configure here.

@haasonsaas haasonsaas merged commit 0182d21 into main Apr 15, 2026
11 checks passed
@haasonsaas haasonsaas deleted the codex/attribution-proto-bootstrap branch April 15, 2026 13:50
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before autofix could start.

Reviewed by Cursor Bugbot for commit 292636f. Configure here.

Comment thread package.json
"./attribution/v1/attribution_pb": {
"types": "./gen/dist/attribution/v1/attribution_pb.d.ts",
"import": "./gen/dist/attribution/v1/attribution_pb.js"
},
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package exports entry breaks alphabetical ordering convention

Low Severity

The ./attribution/v1/attribution_pb export is placed between agents and approvals, but alphabetically approvals (a-p-p) sorts before attribution (a-t-t). Every other entry in the exports map follows strict alphabetical order. Placing attribution after approvals and before audit would maintain the convention and reduce future merge-conflict risk.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 292636f. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant