Conversation
PR SummaryLow Risk Overview Checks in regenerated Go/Connect, Python, and TypeScript artifacts for the new API, updates Reviewed by Cursor Bugbot for commit 292636f. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before autofix could start.
Reviewed by Cursor Bugbot for commit 292636f. Configure here.
| "./attribution/v1/attribution_pb": { | ||
| "types": "./gen/dist/attribution/v1/attribution_pb.d.ts", | ||
| "import": "./gen/dist/attribution/v1/attribution_pb.js" | ||
| }, |
There was a problem hiding this comment.
Package exports entry breaks alphabetical ordering convention
Low Severity
The ./attribution/v1/attribution_pb export is placed between agents and approvals, but alphabetically approvals (a-p-p) sorts before attribution (a-t-t). Every other entry in the exports map follows strict alphabetical order. Placing attribution after approvals and before audit would maintain the convention and reduce future merge-conflict risk.
Reviewed by Cursor Bugbot for commit 292636f. Configure here.


Summary\n- add the initial attribution.v1 service contract for persisted deal attribution reports and export\n- generate Go, Python, and TypeScript artifacts plus package exports\n- extend proto CI smoke coverage to include the new package\n\n## Validation\n- buf lint --path proto/attribution/v1/attribution.proto\n- buf generate --path proto/attribution/v1/attribution.proto --timeout 10m\n- go test ./... -count=1\n- actionlint .github/workflows/ci.yml\n- npm ci && npm run check:package