Skip to content

Add attribution report listing contract#77

Merged
haasonsaas merged 1 commit intomainfrom
codex/attribution-list-reports-auth
Apr 15, 2026
Merged

Add attribution report listing contract#77
haasonsaas merged 1 commit intomainfrom
codex/attribution-list-reports-auth

Conversation

@haasonsaas
Copy link
Copy Markdown
Contributor

Summary

  • add ListReports to AttributionService
  • add AttributionReportSummary plus paginated list request/response types
  • regenerate Go, TS, and Python attribution bindings

Why

The attribution bootstrap can generate and fetch individual reports, but it has no way to browse persisted reports. This adds the operator-facing contract needed for report history and filtering.

Verification

  • buf generate --path proto/attribution/v1/attribution.proto --timeout 10m
  • buf lint --path proto/attribution/v1/attribution.proto
  • go test ./... -count=1
  • npm run check:package

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 15, 2026

PR Summary

Medium Risk
Adds a new public RPC and new request/response message types, requiring server implementations and updating client integrations across languages. Risk is mostly compatibility/contract-related since changes are confined to protobuf/SDK generation.

Overview
Adds a new AttributionService.ListReports unary RPC to enable browsing persisted attribution reports with pagination.

Introduces AttributionReportSummary plus ListReportsRequest/ListReportsResponse (including limit/offset, organization_id/workspace_id, model, and has_more) and regenerates the Go (including Connect stubs), TypeScript, and Python generated bindings to expose the new API.

Reviewed by Cursor Bugbot for commit 342426f. Bugbot is set up for automated code reviews on this repo. Configure here.

@haasonsaas haasonsaas merged commit d484cec into main Apr 15, 2026
9 checks passed
@haasonsaas haasonsaas deleted the codex/attribution-list-reports-auth branch April 15, 2026 14:29
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before autofix could start.

Reviewed by Cursor Bugbot for commit 342426f. Configure here.

message ListReportsResponse {
repeated AttributionReportSummary reports = 1;
bool has_more = 2;
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pagination response inconsistent with codebase convention

Low Severity

ListReportsResponse uses bool has_more for pagination metadata, but every other list response in the codebase (ListResponse, ListDelegationsResponse, ListPendingResponse, audit list response) consistently uses int32 total. This divergence from the established convention means any shared pagination UI components or helper logic built around total won't work with this new endpoint, and developers familiar with the existing pattern may be surprised.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 342426f. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant