Add attribution report listing contract#77
Conversation
PR SummaryMedium Risk Overview Introduces Reviewed by Cursor Bugbot for commit 342426f. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before autofix could start.
Reviewed by Cursor Bugbot for commit 342426f. Configure here.
| message ListReportsResponse { | ||
| repeated AttributionReportSummary reports = 1; | ||
| bool has_more = 2; | ||
| } |
There was a problem hiding this comment.
Pagination response inconsistent with codebase convention
Low Severity
ListReportsResponse uses bool has_more for pagination metadata, but every other list response in the codebase (ListResponse, ListDelegationsResponse, ListPendingResponse, audit list response) consistently uses int32 total. This divergence from the established convention means any shared pagination UI components or helper logic built around total won't work with this new endpoint, and developers familiar with the existing pattern may be surprised.
Reviewed by Cursor Bugbot for commit 342426f. Configure here.


Summary
ListReportstoAttributionServiceAttributionReportSummaryplus paginated list request/response typesWhy
The attribution bootstrap can generate and fetch individual reports, but it has no way to browse persisted reports. This adds the operator-facing contract needed for report history and filtering.
Verification
buf generate --path proto/attribution/v1/attribution.proto --timeout 10mbuf lint --path proto/attribution/v1/attribution.protogo test ./... -count=1npm run check:package